Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): opt-out telemetry and fix sentry dsn provisioning #3041 #3056

Merged
merged 1 commit into from
May 4, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

Signed-off-by: Rogério Peixoto [email protected]

Closes #3041

Proposed Changes

  • add KICS_COLLECT_TELEMETRY environment variable that can disable sentry telemetry if set to 0 or false
  • fixing ldflags provisioning for goreleaser, dockerfiles and github actions

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added the go Pull requests that update Go code label Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx self-assigned this Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/disable-telemetry-fix-ldflags branch 3 times, most recently from 620fb6e to b741144 Compare April 30, 2021 16:07
@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/disable-telemetry-fix-ldflags branch from b741144 to aada21d Compare April 30, 2021 16:34
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 429f218 into master May 4, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/disable-telemetry-fix-ldflags branch May 4, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report about telemetry enabled in used software
2 participants