Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(performance): concurrent engine scans by platform #3061

Merged
merged 13 commits into from
May 4, 2021
Merged

feat(performance): concurrent engine scans by platform #3061

merged 13 commits into from
May 4, 2021

Conversation

joaoReigota1
Copy link
Collaborator

@joaoReigota1 joaoReigota1 commented Apr 30, 2021 •
edited
Loading

Signed-off-by: João Reigota [email protected]

Closes #3085

Proposed Changes

  • Run kics concurrently by platform
  • changed progress bar location
  • changed parser build to return an array of parsers
  • Changed Metrics Locations to prevent errors

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added enhancement Enhancement go Pull requests that update Go code labels Apr 30, 2021
@joaoReigota1 joaoReigota1 added this to the Core Engineering milestone Apr 30, 2021
@joaoReigota1 joaoReigota1 self-assigned this Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title enhancement(engine): Improve KICS performance with concurrent scanning feat(engine): concurrent scanning by platform - performance improvement Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title feat(engine): concurrent scanning by platform - performance improvement feat(performance): engine scans concurrently by platform Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title feat(performance): engine scans concurrently by platform feat(performance): concurrent engine scans by platform Apr 30, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 4, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 4, 2021 •
edited
Loading

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

@joaoReigota1 joaoReigota1 marked this pull request as ready for review May 4, 2021 11:41
felipe-avelar
felipe-avelar suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the single comment, it looks good to me

pkg/scanner/scanner.go Outdated Show resolved Hide resolved
felipe-avelar
felipe-avelar previously approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rogeriopeixotocx
rogeriopeixotocx approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@rogeriopeixotocx rogeriopeixotocx merged commit ba78d64 into master May 4, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the enhancement/add_workers branch May 4, 2021 14:14
@kaplanlior kaplanlior mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@felipe-avelar felipe-avelar felipe-avelar left review comments

Assignees

@joaoReigota1 joaoReigota1

Labels
enhancement Enhancement go Pull requests that update Go code
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

Enhance KICS Performance
4 participants
@joaoReigota1 @kicsbot @rogeriopeixotocx @felipe-avelar