Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): added flag to define default name #3441

Merged
merged 2 commits into from
May 26, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar [email protected]

Closes #2964

Proposed Changes

  • Added flag to define default name
  • Changed output-path behavior, now it will ignore paths with files

I submit this contribution under the Apache-2.0 license.

@felipe-avelar felipe-avelar added feature New feature go Pull requests that update Go code labels May 26, 2021
@felipe-avelar felipe-avelar added this to the CLI/UI milestone May 26, 2021
@felipe-avelar felipe-avelar self-assigned this May 26, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 26, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 26, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Signed-off-by: Felipe Avelar <[email protected]>
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 523fd49 into master May 26, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/output-name branch May 26, 2021 15:48
@milesflo
Copy link

Fantastic solution, tyvm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify Name of Output Files written to output-path
5 participants