Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(query): Updated AD Admin Not Configured For SQL Server for Terraform #3496

Merged
merged 1 commit into from
May 31, 2021
Merged

update(query): Updated AD Admin Not Configured For SQL Server for Terraform #3496

merged 1 commit into from
May 31, 2021

Conversation

joaoReigota1
Copy link
Collaborator

@joaoReigota1 joaoReigota1 commented May 31, 2021 •
edited
Loading

Signed-off-by: João Reigota [email protected]

Closes #3437

Proposed Changes

  • Added case where server_name is passed like server_name= azurerm_sql_server.test.name and removed checking the resource_group

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added query New query feature accuracy Query accuracy (FN and FP) labels May 31, 2021
@joaoReigota1 joaoReigota1 added this to the Queries Support milestone May 31, 2021
@joaoReigota1 joaoReigota1 requested a review from a team May 31, 2021 13:48
@joaoReigota1 joaoReigota1 self-assigned this May 31, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 31, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 31, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

rogeriopeixotocx
rogeriopeixotocx approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 17ab819 into master May 31, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/update_admin_not_configured_sql_server branch May 31, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

Assignees

@joaoReigota1 joaoReigota1

Labels
accuracy Query accuracy (FN and FP) query New query feature
Projects
None yet
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.

FP in 'AD Admin Not Configured For SQL Server' query for Terraform
3 participants
@joaoReigota1 @kicsbot @rogeriopeixotocx