Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(metrics): Metrics default to 'ms' and 'b' for 'ci' flag #3504

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #3477 #3476

Proposed Changes

  • Metrics and scanning time will now return formatted as ms for time and 'B' for memory for --ci flag

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added enhancement Enhancement feature New feature go Pull requests that update Go code labels Jun 1, 2021
@joaoReigota1 joaoReigota1 requested a review from a team June 1, 2021 10:18
@joaoReigota1 joaoReigota1 self-assigned this Jun 1, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 1, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jun 1, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx linked an issue Jun 1, 2021 that may be closed by this pull request
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 24191c5 into master Jun 1, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/make_flag_ci_not_format_units branch June 1, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan duration in log should be displayed in milis profiling metrics - memory should be displayed in bytes
4 participants