Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): yaml parser panics on templated files #3529 #3531

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix(parser): yaml parser panics on templated files #3529 #3531

merged 1 commit into from
Jun 7, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

Closes #3529

Proposed Changes

  • Fix yaml parser panics on templated files due to unchecked type assertion

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added bug Something isn't working go Pull requests that update Go code labels Jun 4, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone Jun 4, 2021
@rogeriopeixotocx rogeriopeixotocx requested review from nunoocx and a team June 4, 2021 09:07
@rogeriopeixotocx rogeriopeixotocx self-assigned this Jun 4, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 4, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jun 4, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

nunoocx
nunoocx approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felipe-avelar
felipe-avelar approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 1b99a4b into master Jun 7, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/yaml-parser-panics-on-templated-files branch June 7, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunoocx nunoocx nunoocx approved these changes

@felipe-avelar felipe-avelar felipe-avelar approved these changes

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

Panic error on parsing YAML file
4 participants
@rogeriopeixotocx @kicsbot @nunoocx @felipe-avelar