Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): install script not adjusting arch from amd64 to x64 #3632

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix(ci): install script not adjusting arch from amd64 to x64 #3632

merged 1 commit into from
Jun 14, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

closes #3631

Proposed Changes

  • fixing install script and replacements section in goreleaser nightly

goreleaser should build amd64 binaries but archive as x64

image

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added the bug Something isn't working label Jun 14, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Internal CI/CD milestone Jun 14, 2021
@rogeriopeixotocx rogeriopeixotocx requested review from elit-cx and a team June 14, 2021 06:17
@rogeriopeixotocx rogeriopeixotocx self-assigned this Jun 14, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 14, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jun 14, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

felipe-avelar
felipe-avelar approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@rogeriopeixotocx rogeriopeixotocx merged commit 479c709 into master Jun 14, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/install-script-arch branch June 14, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-avelar felipe-avelar felipe-avelar approved these changes

@elit-cx elit-cx Awaiting requested review from elit-cx

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
bug Something isn't working
Projects
None yet
Milestone
Internal CI/CD
Development

Successfully merging this pull request may close these issues.

Install script not adjusting arch from amd64 to x64
3 participants
@rogeriopeixotocx @kicsbot @felipe-avelar