Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): generate different similarity id for each unpinned package #3675 #3673

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix(query): generate different similarity id for each unpinned package #3675 #3673

merged 1 commit into from
Jun 16, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx commented Jun 16, 2021 •
edited
Loading

Closes #3675

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added bug Something isn't working query New query feature labels Jun 16, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Query Accuracy milestone Jun 16, 2021
@rogeriopeixotocx rogeriopeixotocx requested review from LeonidWeinberg and a team June 16, 2021 09:04
@rogeriopeixotocx rogeriopeixotocx self-assigned this Jun 16, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 16, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jun 16, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx linked an issue Jun 16, 2021 that may be closed by this pull request
Similarity ID duplication #3675
Closed
@rogeriopeixotocx rogeriopeixotocx changed the title fix(query): generate different similarity id for each unpinned package fix(query): generate different similarity id for each unpinned package #3675 Jun 16, 2021
@rogeriopeixotocx
Copy link
Contributor Author

using searchValue to produce distinct results in this scenario

felipe-avelar
felipe-avelar approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit a0f3d8d into master Jun 16, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/pinned_packages_different_similarity_id branch June 16, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-avelar felipe-avelar felipe-avelar approved these changes

@LeonidWeinberg LeonidWeinberg Awaiting requested review from LeonidWeinberg

@markmishaevcx markmishaevcx Awaiting requested review from markmishaevcx

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
bug Something isn't working query New query feature
Projects
None yet
Milestone
Query Accuracy
Development

Successfully merging this pull request may close these issues.

Similarity ID duplication
3 participants
@rogeriopeixotocx @kicsbot @felipe-avelar