Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector): panic with docker detector multilineSpliter #3784 #3786

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #3784

Proposed Changes

  • Fixed Panic with Docker Detector multilineSpliter

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added bug Something isn't working go Pull requests that update Go code labels Jun 30, 2021
@joaoReigota1 joaoReigota1 requested a review from a team June 30, 2021 10:57
@joaoReigota1 joaoReigota1 self-assigned this Jun 30, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 30, 2021

Scan submitted to Checkmarx

felipe-avelar
felipe-avelar previously approved these changes Jun 30, 2021
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@kicsbot
Copy link
Contributor

kicsbot commented Jun 30, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx dismissed stale reviews from felipe-avelar and themself via 0deed73 June 30, 2021 11:13
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kicsbot
Copy link
Contributor

kicsbot commented Jun 30, 2021

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@rogeriopeixotocx rogeriopeixotocx changed the title fix(detector): Fix Panic with Docker Detector multilineSpliter #3784 fix(detector): panic with docker detector multilineSpliter #3784 Jun 30, 2021
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit a1da5ee into master Jun 30, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_detector_bug branch June 30, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KICS panics during docker detect line
4 participants