-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add --input-data option #3808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Avelar <[email protected]>
Signed-off-by: Felipe Avelar <[email protected]>
felipe-avelar
added
feature
New feature
community
Community contribution
go
Pull requests that update Go code
labels
Jul 2, 2021
Scan submitted to Checkmarx |
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
changed the title
feat(query): Added input data option
feat(query): add --input-data option
Jul 5, 2021
Signed-off-by: Felipe Avelar <[email protected]>
joaoReigota1
requested changes
Jul 7, 2021
assets/queries/common/passwords_and_secrets_in_infrastructure_code/metadata.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few suggestions
assets/queries/common/passwords_and_secrets_in_infrastructure_code/data.json
Outdated
Show resolved
Hide resolved
assets/queries/common/passwords_and_secrets_in_infrastructure_code/data.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
approved these changes
Jul 10, 2021
joaoReigota1
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3807
Proposed Changes
This implementation will require to update queries that makes sense to customize received data, like passwords queries, for example.
To use this feature, we must add
data.<data_variable>
on query and create a filedata.json
that will have all data variables as keys.To customize data, you need to use
--input-data
flag, pointing to a folder with files in the format <query_id>.json and replace ALL keys with your own values.This will be documented as soon as this PR is merged to master
I submit this contribution under the Apache-2.0 license.