Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Fix Passwords query FN #3886

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Proposed Changes

  • Removed Chars regex check for secrets

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added bug Something isn't working query New query feature accuracy Query accuracy (FN and FP) labels Jul 19, 2021
@joaoReigota1 joaoReigota1 requested a review from a team July 19, 2021 11:53
@joaoReigota1 joaoReigota1 self-assigned this Jul 19, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jul 19, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jul 19, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit b2c65eb into master Jul 20, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_passwords_query branch July 20, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy Query accuracy (FN and FP) bug Something isn't working query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants