Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(docs): fixed CSV export on queries page #3890

Merged
merged 1 commit into from
Jul 22, 2021
Merged

bugfix(docs): fixed CSV export on queries page #3890

merged 1 commit into from
Jul 22, 2021

Conversation

felipe-avelar
Copy link
Contributor

@felipe-avelar felipe-avelar commented Jul 20, 2021 •
edited by rogeriopeixotocx
Loading

Signed-off-by: Felipe Avelar [email protected]

Proposed Changes

  • Fixed typo on regex that was not replacing \n characters with white spaces
  • Updated script to split query id and query name and put them in two different columns

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Jul 20, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jul 20, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx changed the title bugfix(docs): Fixed CSV export on queries page bugfix(docs): fixed CSV export on queries page Jul 21, 2021
@felipe-avelar felipe-avelar self-assigned this Jul 21, 2021
@felipe-avelar felipe-avelar added the documentation Improvements or additions to documentation label Jul 21, 2021
@felipe-avelar felipe-avelar added this to the Documentation milestone Jul 21, 2021
joaoReigota1
joaoReigota1 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 6a945c7 into master Jul 22, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the bugfix/docs-csv-queries branch July 22, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@rafaela-soares rafaela-soares Awaiting requested review from rafaela-soares

Assignees

@felipe-avelar felipe-avelar

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Documentation
Development

Successfully merging this pull request may close these issues.
4 participants
@felipe-avelar @kicsbot @joaoReigota1 @rogeriopeixotocx