Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spelling mistake in scan.go #4015

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Conversation

Homopatrol
Copy link
Contributor

Proposed Changes
"accetps" -> "accepts"

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Aug 10, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Aug 10, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx changed the title Fixed spelling mistake in scan.go fix: spelling mistake in scan.go Aug 11, 2021
@rogeriopeixotocx
Copy link
Contributor

rogeriopeixotocx commented Aug 11, 2021

Hi @Homopatrol can you also fix this typo in the following files?
https://github.com/Checkmarx/kics/blob/master/e2e/fixtures/assets/scan_help#L23
https://github.com/Checkmarx/kics/blob/master/docs/commands.md

This is specially important for our E2E tests

@kicsbot
Copy link
Contributor

kicsbot commented Aug 11, 2021

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@Homopatrol
Copy link
Contributor Author

@rogeriopeixotocx okay i've updated those files as well 👍🏽

@rogeriopeixotocx
Copy link
Contributor

rogeriopeixotocx commented Aug 13, 2021

Hi @Homopatrol could you please rebase your branch to the current master branch?
I'm really sorry for the inconvenience.
The PR checks should be green ✅ after this and we can merge this PR.

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @Homopatrol

@rogeriopeixotocx rogeriopeixotocx merged commit c068fe0 into Checkmarx:master Aug 13, 2021
@kaplanlior kaplanlior added the community Community contribution label Aug 17, 2021
@rafaela-soares rafaela-soares added the documentation Improvements or additions to documentation label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants