Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): changed severity, description text and URL in "Liveness Probe Is Not Defined" query #4834

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix(query): changed severity, description text and URL in "Liveness Probe Is Not Defined" query #4834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/queries/k8s/liveness_probe_is_not_defined/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"id": "ade74944-a674-4e00-859e-c6eab5bde441",
"queryName": "Liveness Probe Is Not Defined",
"severity": "MEDIUM",
"severity": "INFO",
"category": "Availability",
"descriptionText": "Liveness Probe must be defined.",
"descriptionUrl": "https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-tcp-liveness-probe",
"descriptionText": "In case of an unresponsive container, a Liveness Probe can help your application become more available since it restarts the container. However, it can lead to cascading failures. Define one if you really need it",
"descriptionUrl": "https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#when-should-you-use-a-liveness-probe",
"platform": "Kubernetes",
"descriptionID": "f724fa60"
}
5 changes: 3 additions & 2 deletions assets/queries/k8s/liveness_probe_is_not_defined/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
[
{
"queryName": "Liveness Probe Is Not Defined",
"severity": "MEDIUM",
"line": 9
"severity": "INFO",
"line": 9,
"fileName": "positive.yaml"
}
]