Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(library): fixed "Generic:354: rego_type_error: rule named engines redeclared at Common:354" #4862

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

rafaela-soares
Copy link
Contributor

@rafaela-soares rafaela-soares commented Feb 21, 2022

Proposed Changes

  • When using a custom common query (platform: "Common" in query metadata), KICS inspector reports the error Generic:354: rego_type_error: rule named engines redeclared at Common:354 and does not load the query. That happens due to the declaration of engines engines := { in common.rego. So, this PR changes it to engines : {

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the bug Something isn't working label Feb 21, 2022
@rafaela-soares rafaela-soares self-assigned this Feb 21, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Feb 21, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.5.1

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit 56ce65d into master Mar 2, 2022
@joaoReigota1 joaoReigota1 deleted the fix/bug_in_common_query_usage branch March 2, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants