Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): Extend memory_requests_not_defined k8s rule to cover further resource kinds #4944

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix(query): Extend memory_requests_not_defined k8s rule to cover further resource kinds #4944

merged 2 commits into from
Mar 16, 2022

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Mar 8, 2022

Proposed Changes

  • Extend the rule to cover additional resource kinds, e.g., Deployment, DaemonSet, etc.
  • New positive test case that covers MissingAttribute in a Deployment
  • More comprehensive description about security implications

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Mar 8, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Mar 8, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

@rafaela-soares rafaela-soares added query New query feature community Community contribution labels Mar 15, 2022
joaoReigota1
joaoReigota1 requested changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Churro, everything looks good to me, the only thing I would like to request here is the use of the searchLine

Thank you for your great contributions

@Churro
Copy link
Contributor Author

Churro commented Mar 15, 2022

Hi @joaoReigota1, thank you for the review. As requested, I've now added the searchLine attribute

rafaela-soares
rafaela-soares approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joaoReigota1 joaoReigota1 merged commit 0ba99cd into Checkmarx:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

Assignees
No one assigned
Labels
community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Churro @kicsbot @rafaela-soares @joaoReigota1