Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(kics): improve KICS overall performance #5112

Merged
merged 2 commits into from
Apr 4, 2022
Merged

update(kics): improve KICS overall performance #5112

merged 2 commits into from
Apr 4, 2022

Conversation

joaoReigota1
Copy link
Collaborator

Proposed Changes

  • KICS now loads queries as they are required instead of preloading them
  • Make use of easyjson for memory issues
  • Fix circle progress bar CPU usage
  • Minor changes to improve performance

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added enhancement Enhancement go Pull requests that update Go code labels Apr 1, 2022
@joaoReigota1 joaoReigota1 added this to the Quality milestone Apr 1, 2022
@joaoReigota1 joaoReigota1 self-assigned this Apr 1, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Apr 1, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Apr 1, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

rafaela-soares
rafaela-soares approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 03cd338 into master Apr 4, 2022
@rafaela-soares rafaela-soares deleted the improve_kics_performance branch April 4, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@joaorufi joaorufi Awaiting requested review from joaorufi

Assignees

@joaoReigota1 joaoReigota1

Labels
enhancement Enhancement go Pull requests that update Go code
Projects
None yet
Milestone
Quality
Development

Successfully merging this pull request may close these issues.
3 participants
@joaoReigota1 @kicsbot @rafaela-soares