Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(scripts): added query metadata validation script #5167

Merged
merged 12 commits into from
Apr 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 139 additions & 0 deletions .github/scripts/queries-validator/metadata-schema.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
{
"type": "object",
"additionalProperties": false,
"definitions": {
"query_id_pattern": {
"type": "string",
"minLength": 1,
"pattern": "^[a-f0-9]{8}-[a-f0-9]{4}-4{1}[a-f0-9]{3}-[89ab]{1}[a-f0-9]{3}-[a-f0-9]{12}$"
},
"description_id_pattern": {
"type": "string",
"minLength": 1,
"pattern": "^[a-f0-9]{8}$"
}
},
"required": [
"id",
"queryName",
"severity",
"category",
"descriptionText",
"descriptionUrl",
"platform",
"descriptionID"
],
"properties": {
"id": {
"$ref": "#/definitions/query_id_pattern"
},
"queryName": {
"type": "string",
"minLength": 8
},
"severity": {
"type": "string",
"enum": [
"TRACE",
"HIGH",
"MEDIUM",
"LOW",
"INFO"
]
},
"category": {
"type": "string",
"enum": [
"Access Control",
"Availability",
"Backup",
"Best Practices",
"Build Process",
"Bill Of Materials",
"Encryption",
"Insecure Configurations",
"Insecure Defaults",
"Networking and Firewall",
"Observability",
"Resource Management",
"Secret Management",
"Supply-Chain",
"Structure and Semantics"
]
},
"descriptionText": {
"type": "string",
"minLength": 16
},
"descriptionUrl": {
"type": "string",
"format": "uri"
},
"cloudProvider": {
"type": "string",
"enum": [
"alicloud",
"aws",
"azure",
"common",
"gcp"
]
},
"platform": {
"type": "string",
"enum": [
"Ansible",
"AzureResourceManager",
"Buildah",
"CloudFormation",
"Common",
"Dockerfile",
"DockerCompose",
"GRPC",
"GoogleDeploymentManager",
"Kubernetes",
"OpenAPI",
"Terraform"
]
},
"descriptionID": {
"$ref": "#/definitions/description_id_pattern"
},
"aggregation": {
"type": "number",
"minimum": 1
},
"override": {
"type": "object",
"additionalProperties": false,
"patternProperties": {
"^\\d[\\.\\d]+$": {
"type": "object",
"additionalProperties": false,
"required": [
"id",
"queryName",
"descriptionUrl"
],
"properties": {
"id": {
"$ref": "#/definitions/query_id_pattern"
},
"queryName": {
"type": "string",
"minLength": 8
},
"descriptionUrl": {
"type": "string",
"format": "uri"
},
"descriptionText": {
"type": "string",
"minLength": 16
}
}
}
}
}
}
}
102 changes: 102 additions & 0 deletions .github/scripts/queries-validator/queries-validator.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
import os
import requests
import json
from pathlib import Path
from jsonschema import validate

KICS_PR_NUMBER = os.getenv('KICS_PR_NUMBER')
KICS_GITHUB_TOKEN = os.getenv('KICS_GITHUB_TOKEN')
QUERIES_PATH = 'assets/queries'
QUERIES_METADATA = 'metadata.json'

def exit_with_error(message):
print(message)
exit(1)

def exit_success():
print('Successfully execution!')
exit(0)

def fetch(page=1, max_items=100):
print('Fetching PR files... #page{}'.format(page))
headers = {'Authorization': 'token {}'.format(KICS_GITHUB_TOKEN)}
url = 'https://api.github.com/repos/checkmarx/kics/pulls/{}/files?per_page={}page={}'.format(KICS_PR_NUMBER, max_items, page)
response = requests.get(url, headers=headers)
return { "data": response.json(), "status": response.status_code }

def fetch_pr_files():
files = []
page = 1
max_items = 100

while page < 50:
response = fetch(page, max_items)
if response['status'] != 200:
return exit_with_error('Failed to fetch PR files\n- status code: {}'.format(response['status']))

for obj in response['data']:
files.append(obj['filename'])

if len(response['data']) < max_items:
return files

page += 1

return exit_with_error('Failed to fetch PR files\n- too many pages')

def find_queries_in_files(files):
queries = []
for file in files:
if file.endswith(QUERIES_METADATA) and file.startswith(QUERIES_PATH):
queries.append(file)
return queries

def validate_queries_metadata(queries):
errors = []

with open('metadata-schema.json') as fileSchema:
schema = json.load(fileSchema)
for i, query in enumerate(queries):
print('[{}] Validating "{}" ...'.format(i,query))

complete_path = os.path.abspath(os.path.join('..', '..', '..', Path(query)))

with open(complete_path) as f:
try:
data = json.load(f)
except json.decoder.JSONDecodeError:
errors.append('Failed to parse {}'.format(query))
try:
validate(instance=data, schema=schema)
except Exception as e:
errors.append('Failed to validate {}: {}'.format(query, e))

if len(errors) > 0:
for error in errors:
print(error)
exit_with_error('There are metadata files with errors ({} files)'.format(len(errors)))

def fetch_all_metadata_files():
complete_path = os.path.abspath(os.path.join('..', '..', '..', 'assets', 'queries'))

queries_list = []
for root, _, files in os.walk(complete_path):
for file in files:
if file.endswith(QUERIES_METADATA):
queries_list.append(os.path.join(root, file))
return queries_list

def validate_all_queries():
queries_list = fetch_all_metadata_files()
validate_queries_metadata(queries_list)
exit_success()

def validate_pr_queries():
changed_files = fetch_pr_files()
queries = find_queries_in_files(changed_files)
validate_queries_metadata(queries)
exit_success()

if __name__ == '__main__':
validate_pr_queries()
#validate_all_queries()
Binary file added .github/scripts/queries-validator/requirements.txt
Binary file not shown.
23 changes: 23 additions & 0 deletions .github/workflows/validate-queries-metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: validate-queries-metadata

on:
pull_request:
paths:
- "assets/queries/**/metadata.json"

jobs:
validate-metadata:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Run queries metadata validation script
env:
KICS_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
KICS_PR_NUMBER: ${{ github.event.number }}
id: validator
working-directory: .github/scripts/queries-validator/
run: |
pip3 install -r requirements.txt
python3 queries-validator.py