Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tracker): Add Resolved File Lines' counter #6501

Merged
merged 11 commits into from
Jul 19, 2023
Merged

fix(Tracker): Add Resolved File Lines' counter #6501

merged 11 commits into from
Jul 19, 2023

Conversation

cx-henriqueAlvelos
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos commented Jul 5, 2023 •
edited
Loading

Proposed Changes

  • Added lines' counter of resolved files
  • Resolved Files only contains referenced files and not objects from them

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos added the bug Something isn't working label Jul 5, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

pereiramarco011
pereiramarco011 suggested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for getPathfromStirng call on Resolved file existence checking

pereiramarco011
pereiramarco011 previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 😄

pereiramarco011
pereiramarco011 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@asofsilva asofsilva merged commit 11f1989 into master Jul 19, 2023
13 checks passed
@asofsilva asofsilva deleted the bug/kics/865 branch July 19, 2023 16:44
@Porkepix Porkepix mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cx-henriqueAlvelos @pereiramarco011 @asofsilva