Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): ddd missing search value in response code missing query for open api #6508

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix(query): ddd missing search value in response code missing query for open api #6508

merged 2 commits into from
Jul 10, 2023

Conversation

cxMiguelSilva
Copy link
Collaborator

Proposed Changes

  • add missing search value to reduce duplicated similarity id

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature openapi OpenAPI query labels Jul 7, 2023
@cxMiguelSilva cxMiguelSilva self-assigned this Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cx-henriqueAlvelos
cx-henriqueAlvelos approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cxMiguelSilva cxMiguelSilva merged commit c7e439f into master Jul 10, 2023
@cxMiguelSilva cxMiguelSilva deleted the fix-response-code-missing-sym-id branch July 10, 2023 09:31
@Porkepix Porkepix mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-henriqueAlvelos cx-henriqueAlvelos cx-henriqueAlvelos approved these changes

@pereiramarco011 pereiramarco011 Awaiting requested review from pereiramarco011

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
bug Something isn't working openapi OpenAPI query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cxMiguelSilva @cx-henriqueAlvelos