Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): cloudformation DynamoDB Table Not Encrypted #6619

Merged
merged 13 commits into from
Feb 8, 2024

Conversation

cx-henriqueAlvelos
Copy link
Contributor

Proposed Changes

  • Query
  • Tests
  • Positive Expected Results

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature cloudformation CloudFormation query labels Aug 8, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@cx-henriqueAlvelos cx-henriqueAlvelos added aws PR related with AWS Cloud cloudformation CloudFormation query and removed cloudformation CloudFormation query labels Aug 8, 2023
@github-actions github-actions bot removed the aws PR related with AWS Cloud label Aug 9, 2023
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cx-henriqueAlvelos,
Please add a valid negative sample to the tests. Also, add samples using JSON to improve test coverage.

Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added community Community contribution feature request Community: new feature request labels Feb 7, 2024
@pereiramarco011 pereiramarco011 merged commit 83c8555 into master Feb 8, 2024
22 checks passed
@pereiramarco011 pereiramarco011 deleted the kics-785-cloudformation branch February 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudformation CloudFormation query community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants