Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): cloudformation cloudFront_without_waf #6641

Merged
merged 13 commits into from
Feb 16, 2024
Merged

fix(query): cloudformation cloudFront_without_waf #6641

merged 13 commits into from
Feb 16, 2024

Conversation

cx-henriqueAlvelos
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos commented Aug 12, 2023 •
edited
Loading

Proposed Changes

  • Policy that checks value of WebACLId
  • Positive Tests
  • Positive expected result

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos added bug Something isn't working query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Aug 12, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 12, 2023
@github-actions github-actions bot removed bug Something isn't working aws PR related with AWS Cloud labels Aug 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cxMiguelSilva
cxMiguelSilva previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot added the community Community contribution label Feb 1, 2024
EduardoSemanas and others added 3 commits February 2, 2024 16:13
@EduardoSemanas
Both the distributionConfig.Enabled and distributionConfig.IPV6Enabled
af77c27 
are checked and the WebACLId is check for not only existing but also for
having a non empty value
@EduardoSemanas
FInal solution after AppSec feedback
4dfe934
@EduardoSemanas
Merged from local branch
f1bca08
cxMiguelSilva
cxMiguelSilva previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoaoAtGit JoaoAtGit merged commit b1e248d into master Feb 16, 2024
21 checks passed
@JoaoAtGit JoaoAtGit deleted the kics-659 branch February 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@pereiramarco011 pereiramarco011 Awaiting requested review from pereiramarco011

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
cloudformation CloudFormation query community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cx-henriqueAlvelos @cxMiguelSilva @JoaoAtGit @gabriel-cx @EduardoSemanas