fix(parser): reduce complexity of initializeJSONLine #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leadpogrommer
force-pushed
the
fix/issue#6806-json-parsing-performance
branch
from
fde4d5d
to
f271be4
Compare
JoaoAtGit
approved these changes
Dec 12, 2023
|
@leadpogrommer I was checking your changes and doing some tests, and thanks for your find :) |
|
@JoaoCxMartins Thank you for reviewing. |
|
Hi @leadpogrommer , we'll have one more version this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6821
Proposed Changes
Reduce computational complexity of initializeJSONLine by resuming line calculation from previous offset
I submit this contribution under the Apache-2.0 license.