Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): sensitive_port_is_exposed_to_entire_network #6916

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

Tohar-orca
Copy link
Contributor

@Tohar-orca Tohar-orca commented Feb 29, 2024

Proposed Changes

  • Fix a false negative in terraform/aws/sensitive_port_is_exposed_to_entire_network in cases where a terraform plan json is scanned instead of a .tf file

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution query New query feature terraform Terraform query aws PR related with AWS Cloud labels Feb 29, 2024
@Tohar-orca Tohar-orca changed the title fix(query): vulnerability_alert_score_epss_features fix(query): sensitive_port_is_exposed_to_entire_network Feb 29, 2024
@gabriel-cx
Copy link
Contributor

hi @Tohar-orca ,

thank you for your contribution!
kindly be aware of this failing unit test:
image

Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tohar-orca kindly add a negative test for the .json file

@Tohar-orca
Copy link
Contributor Author

Thanks @gabriel-cx I've fixed the unit tests and added a negative.json file
It seems the tests are failing on something unrelated though, could you please re-run them?

@gabriel-cx
Copy link
Contributor

No problem @Tohar-orca !
I will re-run the tests, the e2e tests sometimes fail but the reason is not related to the PR's changes (re-run make them pass), and is the case here! We have a fix for it on the way!

@gabriel-cx gabriel-cx merged commit 4c4c625 into Checkmarx:master Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud community Community contribution query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants