fix(githubactions): github actions relative path detected as not pinned #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
community
cw-alexcroteau
changed the title
cw-alexcroteau
changed the title
JoaoAtGit
reviewed
Mar 28, 2024
| @@ -28,3 +29,8 @@ isPinned(use){ | |||
| regex.match("@[a-f0-9]{40}$", use) | |||
| } | |||
|
|
|||
| isRelative(use){ | |||
| allowed := ["./", "../"] | |||
There was a problem hiding this comment.
Hi @cw-alexcroteau.
First, thank you for your contribution :).
I'm with one doubt, relative to the "../".
Why do you feel the necessity to support the "../" ?
There was a problem hiding this comment.
Hi, you are right, no need to support it. I completely missed your reply and carried on, let me remove that and sync my fork.
|
Hi @cw-alexcroteau , |
Hi @JoaoCxMartins, thanks for the heads up, it's now synced. |
JoaoAtGit
approved these changes
Apr 22, 2024
|
Hi @cw-alexcroteau TY for your contribution to kics :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6957
Proposed Changes
I submit this contribution under the Apache-2.0 license.