Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flow): save flow #7083

Merged
merged 19 commits into from
Jun 5, 2024
Merged

fix(flow): save flow #7083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5ffa984
save flow
JoaoAtGit May 27, 2024
2c17f5d
Merge branch 'refs/heads/master' into joao/save_flow
JoaoAtGit May 28, 2024
5fd2efc
wip
JoaoAtGit May 28, 2024
80bcd40
wip
JoaoAtGit May 28, 2024
8d4a43f
Merge branch 'master' into joao/save_flow
JoaoAtGit May 28, 2024
1abed0b
wip
JoaoAtGit May 28, 2024
cb1577b
Merge branch 'joao/save_flow' of github.com:Checkmarx/kics into joao/…
JoaoAtGit May 28, 2024
203138e
Merge branch 'master' into joao/save_flow
JoaoAtGit May 28, 2024
1916320
improve compare
JoaoAtGit May 28, 2024
20418e4
clean
JoaoAtGit May 28, 2024
685e7fa
Merge branch 'master' into joao/save_flow
JoaoAtGit May 28, 2024
f5d8362
linter
JoaoAtGit May 28, 2024
3992d71
linter
JoaoAtGit May 28, 2024
cee65da
Merge branch 'master' into joao/save_flow
cx-andrep Jun 5, 2024
b900253
update version
JoaoAtGit Jun 5, 2024
af8e679
Merge remote-tracking branch 'origin/joao/save_flow' into joao/save_flow
JoaoAtGit Jun 5, 2024
ba1d783
Merge branch 'master' into joao/save_flow
cx-andrep Jun 5, 2024
17929f7
Merge branch 'refs/heads/master' into joao/save_flow
JoaoAtGit Jun 5, 2024
87876cd
Merge remote-tracking branch 'origin/joao/save_flow' into joao/save_flow
JoaoAtGit Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 40 additions & 40 deletions e2e/fixtures/E2E_CLI_032_RESULT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
},
"total_counter": 24,
"total_bom_resources": 0,
"start": "2024-04-29T15:36:07.7321463+01:00",
"end": "2024-04-29T15:36:22.007629+01:00",
"start": "2024-05-28T13:21:07.0046236+01:00",
"end": "2024-05-28T13:21:21.5156346+01:00",
"paths": [
"/path/e2e/fixtures/samples/positive.yaml"
],
Expand All @@ -40,29 +40,29 @@
"files": [
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "5f39aa8e63613a7e8bfd7641ccfb931fa0225e95b3449bc1210b50329d65d713",
"line": 32,
"similarity_id": "88653ab159ca0a15095afc685f98da24685fa547bb5f1ca7c95ef468f209387c",
"line": 24,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupSSHinbound",
"resource_name": "EcsSecurityGroupHTTPinbound02",
"issue_type": "IncorrectValue",
"search_key": "Resources.EcsSecurityGroupSSHinbound.Properties.CidrIp",
"search_key": "Resources.EcsSecurityGroupHTTPinbound02.Properties.CidrIp",
"search_line": -1,
"search_value": "",
"expected_value": "Resource name 'EcsSecurityGroupSSHinbound' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from all IPv4 adresses and to all available ports",
"actual_value": "Resource name 'EcsSecurityGroupSSHinbound' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from CIDR 0.0.0.0/0 to all available ports"
"expected_value": "Resource name 'EcsSecurityGroupHTTPinbound02' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from all IPv4 adresses and to all available ports",
"actual_value": "Resource name 'EcsSecurityGroupHTTPinbound02' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from CIDR 0.0.0.0/0 to all available ports"
},
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "88653ab159ca0a15095afc685f98da24685fa547bb5f1ca7c95ef468f209387c",
"line": 24,
"similarity_id": "5f39aa8e63613a7e8bfd7641ccfb931fa0225e95b3449bc1210b50329d65d713",
"line": 32,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupHTTPinbound02",
"resource_name": "EcsSecurityGroupSSHinbound",
"issue_type": "IncorrectValue",
"search_key": "Resources.EcsSecurityGroupHTTPinbound02.Properties.CidrIp",
"search_key": "Resources.EcsSecurityGroupSSHinbound.Properties.CidrIp",
"search_line": -1,
"search_value": "",
"expected_value": "Resource name 'EcsSecurityGroupHTTPinbound02' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from all IPv4 adresses and to all available ports",
"actual_value": "Resource name 'EcsSecurityGroupHTTPinbound02' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from CIDR 0.0.0.0/0 to all available ports"
"expected_value": "Resource name 'EcsSecurityGroupSSHinbound' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from all IPv4 adresses and to all available ports",
"actual_value": "Resource name 'EcsSecurityGroupSSHinbound' of type 'AWS::EC2::SecurityGroupIngress' should not accept ingress connections from CIDR 0.0.0.0/0 to all available ports"
}
]
},
Expand Down Expand Up @@ -197,7 +197,7 @@
"files": [
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "27c1aa11c215cb09ce1ad1e569a090d5bc80ca156c5bf81f3b52415dbd6608f0",
"similarity_id": "7d59e0095d8eda260b02394f129910d70d01b55dffb356780166354f9360d848",
"line": 104,
"resource_type": "AWS::ElasticLoadBalancingV2::Listener",
"resource_name": "ALBListener",
Expand Down Expand Up @@ -357,6 +357,19 @@
"description": "AWS Security Group Ingress should have a single port",
"description_id": "5f2b65f3",
"files": [
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "d60022e14f1b45c574f71c0f48b3fee882b471819597b770e3545988a8f5295a",
"line": 19,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupHTTPinbound02",
"issue_type": "IncorrectValue",
"search_key": "Resources.EcsSecurityGroupHTTPinbound02.Properties",
"search_line": -1,
"search_value": "",
"expected_value": "Resources.EcsSecurityGroupHTTPinbound02.Properties.FromPort should equal to Resources.EcsSecurityGroupHTTPinbound02.Properties.ToPort",
"actual_value": "Resources.EcsSecurityGroupHTTPinbound02.Properties.FromPort is not equal to Resources.EcsSecurityGroupHTTPinbound02.Properties.ToPort"
},
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "000056cd0b9697e13f2f4561f1963e34c58c042b921c4d0fad0f2fa5214374eb",
Expand All @@ -382,19 +395,6 @@
"search_value": "",
"expected_value": "Resources.EcsSecurityGroupSSHinbound.Properties.FromPort should equal to Resources.EcsSecurityGroupSSHinbound.Properties.ToPort",
"actual_value": "Resources.EcsSecurityGroupSSHinbound.Properties.FromPort is not equal to Resources.EcsSecurityGroupSSHinbound.Properties.ToPort"
},
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "d60022e14f1b45c574f71c0f48b3fee882b471819597b770e3545988a8f5295a",
"line": 19,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupHTTPinbound02",
"issue_type": "IncorrectValue",
"search_key": "Resources.EcsSecurityGroupHTTPinbound02.Properties",
"search_line": -1,
"search_value": "",
"expected_value": "Resources.EcsSecurityGroupHTTPinbound02.Properties.FromPort should equal to Resources.EcsSecurityGroupHTTPinbound02.Properties.ToPort",
"actual_value": "Resources.EcsSecurityGroupHTTPinbound02.Properties.FromPort is not equal to Resources.EcsSecurityGroupHTTPinbound02.Properties.ToPort"
}
]
},
Expand Down Expand Up @@ -533,16 +533,16 @@
"files": [
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "95883c9f983adb8f547c54e24837b6aa402978a00417be98441514959d4171d4",
"line": 27,
"similarity_id": "39fec612777f59fb4181dd2330ee465ec860c962acfebb07a4f1ee1f122d24e7",
"line": 35,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupSSHinbound",
"resource_name": "EcsSecurityGroupALBports",
"issue_type": "MissingAttribute",
"search_key": "Resources.EcsSecurityGroupSSHinbound.Properties",
"search_key": "Resources.EcsSecurityGroupALBports.Properties",
"search_line": -1,
"search_value": "",
"expected_value": "Resources.EcsSecurityGroupSSHinbound.Properties.Description should be set",
"actual_value": "Resources.EcsSecurityGroupSSHinbound.Properties.Description is undefined"
"expected_value": "Resources.EcsSecurityGroupALBports.Properties.Description should be set",
"actual_value": "Resources.EcsSecurityGroupALBports.Properties.Description is undefined"
},
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
Expand All @@ -559,16 +559,16 @@
},
{
"file_name": "/path/e2e/fixtures/samples/positive.yaml",
"similarity_id": "39fec612777f59fb4181dd2330ee465ec860c962acfebb07a4f1ee1f122d24e7",
"line": 35,
"similarity_id": "95883c9f983adb8f547c54e24837b6aa402978a00417be98441514959d4171d4",
"line": 27,
"resource_type": "AWS::EC2::SecurityGroupIngress",
"resource_name": "EcsSecurityGroupALBports",
"resource_name": "EcsSecurityGroupSSHinbound",
"issue_type": "MissingAttribute",
"search_key": "Resources.EcsSecurityGroupALBports.Properties",
"search_key": "Resources.EcsSecurityGroupSSHinbound.Properties",
"search_line": -1,
"search_value": "",
"expected_value": "Resources.EcsSecurityGroupALBports.Properties.Description should be set",
"actual_value": "Resources.EcsSecurityGroupALBports.Properties.Description is undefined"
"expected_value": "Resources.EcsSecurityGroupSSHinbound.Properties.Description should be set",
"actual_value": "Resources.EcsSecurityGroupSSHinbound.Properties.Description is undefined"
}
]
}
Expand Down
Loading
Loading