Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(queries): prefix "(beta)" added to queries that are still under review #7085

Merged
merged 3 commits into from
May 28, 2024
Merged

update(queries): prefix "(beta)" added to queries that are still under review #7085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d13eddf
update(queries): beta label added to queries that are still under review
gabriel-cx May 28, 2024
ddf1694
tests updated
gabriel-cx May 28, 2024
59a69ad
Merge branch 'master' into adding-beta-label
gabriel-cx May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/autoscale_badly_setup/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "953c0cc6-5f30-44cb-a803-bf4ef2571be8",
"queryName": "Databricks Autoscale Badly Setup",
"queryName": "(Beta) Databricks Autoscale Badly Setup",
"severity": "MEDIUM",
"category": "Resource Management",
"descriptionText": "Databricks should have min and max worker setup for autoscale",
Expand Down
4 changes: 2 additions & 2 deletions assets/queries/terraform/databricks/autoscale_badly_setup/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Databricks Autoscale Badly Setup",
"queryName": "(Beta) Databricks Autoscale Badly Setup",
"severity": "MEDIUM",
"line": 6,
"fileName": "positive1.tf"
},
{
"queryName": "Databricks Autoscale Badly Setup",
"queryName": "(Beta) Databricks Autoscale Badly Setup",
"severity": "MEDIUM",
"line": 6,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/cluster_aws_attributes/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "b0749c53-e3ff-4d09-bbe4-dca94e2e7a38",
"queryName": "Check Databricks Cluster AWS Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster AWS Attribute Best Practices",
"severity": "LOW",
"category": "Best Practices",
"descriptionText": "One or some Databricks Cluster AWS Attribute Best Practices are not respected",
Expand Down
8 changes: 4 additions & 4 deletions ...ts/queries/terraform/databricks/cluster_aws_attributes/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
[
{
"queryName": "Check Databricks Cluster AWS Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster AWS Attribute Best Practices",
"severity": "LOW",
"line": 11,
"fileName": "positive1.tf"
},
{
"queryName": "Check Databricks Cluster AWS Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster AWS Attribute Best Practices",
"severity": "LOW",
"line": 13,
"fileName": "positive2.tf"
},
{
"queryName": "Check Databricks Cluster AWS Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster AWS Attribute Best Practices",
"severity": "LOW",
"line": 10,
"fileName": "positive3.tf"
},
{
"queryName": "Check Databricks Cluster AWS Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster AWS Attribute Best Practices",
"severity": "LOW",
"line": 12,
"fileName": "positive4.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/cluster_azure_attributes/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "38028698-e663-4ef7-aa92-773fef0ca86f",
"queryName": "Check Databricks Cluster Azure Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster Azure Attribute Best Practices",
"severity": "LOW",
"category": "Best Practices",
"descriptionText": "One or some Databricks Cluster Azure Attribute Best Practices are not respected",
Expand Down
6 changes: 3 additions & 3 deletions .../queries/terraform/databricks/cluster_azure_attributes/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
[
{
"queryName": "Check Databricks Cluster Azure Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster Azure Attribute Best Practices",
"severity": "LOW",
"line": 11,
"fileName": "positive1.tf"
},
{
"queryName": "Check Databricks Cluster Azure Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster Azure Attribute Best Practices",
"severity": "LOW",
"line": 12,
"fileName": "positive2.tf"
},
{
"queryName": "Check Databricks Cluster Azure Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster Azure Attribute Best Practices",
"severity": "LOW",
"line": 10,
"fileName": "positive3.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/cluster_gcp_attributes/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "539e4557-d2b5-4d57-a001-cb01140a4e2d",
"queryName": "Check Databricks Cluster GCP Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster GCP Attribute Best Practices",
"severity": "LOW",
"category": "Best Practices",
"descriptionText": "One or some Databricks Cluster GCP Attribute Best Practices are not respected",
Expand Down
2 changes: 1 addition & 1 deletion ...ts/queries/terraform/databricks/cluster_gcp_attributes/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Check Databricks Cluster GCP Attribute Best Practices",
"queryName": "(Beta) Check Databricks Cluster GCP Attribute Best Practices",
"severity": "LOW",
"line": 11,
"fileName": "positive1.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/databricks_permissions/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "a4edb7e1-c0e0-4f7f-9d7c-d1b603e81ad5",
"queryName": "Databricks Cluster or Job With None Or Insecure Permission(s)",
"queryName": "(Beta) Databricks Cluster or Job With None Or Insecure Permission(s)",
"severity": "HIGH",
"category": "Insecure Configurations",
"descriptionText": "Databricks Cluster and Job must have restricted permissions",
Expand Down
8 changes: 4 additions & 4 deletions ...ts/queries/terraform/databricks/databricks_permissions/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
[
{
"queryName": "Databricks Cluster or Job With None Or Insecure Permission(s)",
"queryName": "(Beta) Databricks Cluster or Job With None Or Insecure Permission(s)",
"severity": "HIGH",
"line": 16,
"fileName": "positive1.tf"
},
{
"queryName": "Databricks Cluster or Job With None Or Insecure Permission(s)",
"queryName": "(Beta) Databricks Cluster or Job With None Or Insecure Permission(s)",
"severity": "HIGH",
"line": 12,
"fileName": "positive2.tf"
},
{
"queryName": "Databricks Cluster or Job With None Or Insecure Permission(s)",
"queryName": "(Beta) Databricks Cluster or Job With None Or Insecure Permission(s)",
"severity": "HIGH",
"line": 16,
"fileName": "positive3.tf"
},
{
"queryName": "Databricks Cluster or Job With None Or Insecure Permission(s)",
"queryName": "(Beta) Databricks Cluster or Job With None Or Insecure Permission(s)",
"severity": "HIGH",
"line": 16,
"fileName": "positive4.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/group_without_user_or_instance_profile/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "23c3067a-8cc9-480c-b645-7c1e0ad4bf60",
"queryName": "Databricks Group Without User Or Instance Profile",
"queryName": "(Beta) Databricks Group Without User Or Instance Profile",
"severity": "LOW",
"category": "Access Control",
"descriptionText": "Databricks Group should have at least one user or one instance profile associated",
Expand Down
4 changes: 2 additions & 2 deletions ...form/databricks/group_without_user_or_instance_profile/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Databricks Group Without User Or Instance Profile",
"queryName": "(Beta) Databricks Group Without User Or Instance Profile",
"severity": "LOW",
"line": 16,
"fileName": "positive1.tf"
},
{
"queryName": "Databricks Group Without User Or Instance Profile",
"queryName": "(Beta) Databricks Group Without User Or Instance Profile",
"severity": "LOW",
"line": 14,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/indefinitely_obo_token/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "23e1f5f0-12b7-4d7e-9087-f60f42ccd514",
"queryName": "Indefinitely Databricks OBO Token Lifetime",
"queryName": "(Beta) Indefinitely Databricks OBO Token Lifetime",
"severity": "MEDIUM",
"category": "Insecure Defaults",
"descriptionText": "OBO Token has an indefinitely lifetime",
Expand Down
2 changes: 1 addition & 1 deletion ...ts/queries/terraform/databricks/indefinitely_obo_token/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Indefinitely Databricks OBO Token Lifetime",
"queryName": "(Beta) Indefinitely Databricks OBO Token Lifetime",
"severity": "MEDIUM",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/indefinitely_token/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "7d05ca25-91b4-42ee-b6f6-b06611a87ce8",
"queryName": "Indefinitely Databricks Token Lifetime",
"queryName": "(Beta) Indefinitely Databricks Token Lifetime",
"severity": "MEDIUM",
"category": "Insecure Defaults",
"descriptionText": "Token has an indefinitely lifetime",
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/indefinitely_token/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Indefinitely Databricks Token Lifetime",
"queryName": "(Beta) Indefinitely Databricks Token Lifetime",
"severity": "MEDIUM",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/unrestricted_acl/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "2c4fe4a9-f44b-4c70-b09b-5b75cd251805",
"queryName": "Unrestricted Databricks ACL",
"queryName": "(Beta) Unrestricted Databricks ACL",
"severity": "HIGH",
"category": "Networking and Firewall",
"descriptionText": "ACL allow ingress from 0.0.0.0/0 and/or ::/0",
Expand Down
4 changes: 2 additions & 2 deletions assets/queries/terraform/databricks/unrestricted_acl/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Unrestricted Databricks ACL",
"queryName": "(Beta) Unrestricted Databricks ACL",
"severity": "HIGH",
"line": 10,
"fileName": "positive1.tf"
},
{
"queryName": "Unrestricted Databricks ACL",
"queryName": "(Beta) Unrestricted Databricks ACL",
"severity": "HIGH",
"line": 10,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/use_lts_spark_version/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "5a627dfa-a4dd-4020-a4c6-5f3caf4abcd6",
"queryName": "Check use no LTS Spark Version",
"queryName": "(Beta) Check use no LTS Spark Version",
"severity": "LOW",
"category": "Best Practices",
"descriptionText": "Spark Version is not a Long-term Support",
Expand Down
6 changes: 3 additions & 3 deletions assets/queries/terraform/databricks/use_lts_spark_version/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
[
{
"queryName": "Check use no LTS Spark Version",
"queryName": "(Beta) Check use no LTS Spark Version",
"severity": "LOW",
"line": 8,
"fileName": "positive1.tf"
},
{
"queryName": "Check use no LTS Spark Version",
"queryName": "(Beta) Check use no LTS Spark Version",
"severity": "LOW",
"line": 11,
"fileName": "positive2.tf"
},
{
"queryName": "Check use no LTS Spark Version",
"queryName": "(Beta) Check use no LTS Spark Version",
"severity": "LOW",
"line": 10,
"fileName": "positive3.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/databricks/use_spark_submit_task/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "375cdab9-3f94-4ae0-b1e3-8fbdf9cdf4d7",
"queryName": "Job's Task is Legacy (spark_submit_task)",
"queryName": "(Beta) Job's Task is Legacy (spark_submit_task)",
"severity": "MEDIUM",
"category": "Best Practices",
"descriptionText": "Job's Task Is spark_submit_task",
Expand Down
4 changes: 2 additions & 2 deletions assets/queries/terraform/databricks/use_spark_submit_task/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Job's Task is Legacy (spark_submit_task)",
"queryName": "(Beta) Job's Task is Legacy (spark_submit_task)",
"severity": "MEDIUM",
"line": 36,
"fileName": "positive1.tf"
},
{
"queryName": "Job's Task is Legacy (spark_submit_task)",
"queryName": "(Beta) Job's Task is Legacy (spark_submit_task)",
"severity": "MEDIUM",
"line": 18,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/computing_instance_has_common_private/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "df58dd45-8009-43c2-90f7-c90eb9d53ed9",
"queryName": "Nifcloud Computing Has Common Private Network",
"queryName": "(Beta) Nifcloud Computing Has Common Private Network",
"severity": "LOW",
"category": "Networking and Firewall",
"descriptionText": "The instance has common private network",
Expand Down
4 changes: 2 additions & 2 deletions ...rraform/nifcloud/computing_instance_has_common_private/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Nifcloud Computing Has Common Private Network",
"queryName": "(Beta) Nifcloud Computing Has Common Private Network",
"severity": "LOW",
"line": 1,
"fileName": "positive1.tf"
},
{
"queryName": "Nifcloud Computing Has Common Private Network",
"queryName": "(Beta) Nifcloud Computing Has Common Private Network",
"severity": "LOW",
"line": 1,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/computing_instance_has_public_ingress_sgr/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "b2ea2367-8dc9-4231-a035-d0b28bfa3dde",
"queryName": "Nifcloud Computing Has Public Ingress Security Group Rule",
"queryName": "(Beta) Nifcloud Computing Has Public Ingress Security Group Rule",
"severity": "HIGH",
"category": "Networking and Firewall",
"descriptionText": "An ingress security group rule allows traffic from /0",
Expand Down
2 changes: 1 addition & 1 deletion ...orm/nifcloud/computing_instance_has_public_ingress_sgr/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Nifcloud Computing Has Public Ingress Security Group Rule",
"queryName": "(Beta) Nifcloud Computing Has Public Ingress Security Group Rule",
"severity": "HIGH",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/computing_instance_security_group_undefined/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "89218b48-75c9-4cb3-aaba-5299e852e8bc",
"queryName": "Nifcloud Computing Undefined Security Group To Instance",
"queryName": "(Beta) Nifcloud Computing Undefined Security Group To Instance",
"severity": "HIGH",
"category": "Networking and Firewall",
"descriptionText": "Missing security group for instance",
Expand Down
2 changes: 1 addition & 1 deletion ...m/nifcloud/computing_instance_security_group_undefined/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Nifcloud Computing Undefined Security Group To Instance",
"queryName": "(Beta) Nifcloud Computing Undefined Security Group To Instance",
"severity": "HIGH",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion ...s/queries/terraform/nifcloud/computing_security_group_description_undefined/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "41c127a9-3a85-4bc3-a333-ed374eb9c3e4",
"queryName": "Nifcloud Computing Undefined Description To Security Group",
"queryName": "(Beta) Nifcloud Computing Undefined Description To Security Group",
"severity": "LOW",
"category": "Networking and Firewall",
"descriptionText": "Missing description for security group",
Expand Down
2 changes: 1 addition & 1 deletion ...ifcloud/computing_security_group_description_undefined/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Nifcloud Computing Undefined Description To Security Group",
"queryName": "(Beta) Nifcloud Computing Undefined Description To Security Group",
"severity": "LOW",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion ...ries/terraform/nifcloud/computing_security_group_rule_description_undefined/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "e4610872-0b1c-4fb7-ab57-d81c0afdb291",
"queryName": "Nifcloud Computing Undefined Description To Security Group Rule",
"queryName": "(Beta) Nifcloud Computing Undefined Description To Security Group Rule",
"severity": "LOW",
"category": "Networking and Firewall",
"descriptionText": "Missing description for security group rule",
Expand Down
2 changes: 1 addition & 1 deletion ...ud/computing_security_group_rule_description_undefined/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Nifcloud Computing Undefined Description To Security Group Rule",
"queryName": "(Beta) Nifcloud Computing Undefined Description To Security Group Rule",
"severity": "LOW",
"line": 1,
"fileName": "positive.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/db_does_not_have_long_backup_retention/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "e5071f76-cbe7-468d-bb2b-d10f02d2b713",
"queryName": "Nifcloud RDB Has Backup Retention Less Than 2 Day",
"queryName": "(Beta) Nifcloud RDB Has Backup Retention Less Than 2 Day",
"severity": "MEDIUM",
"category": "Backup",
"descriptionText": "The rdb has backup retention less than 2 day",
Expand Down
4 changes: 2 additions & 2 deletions ...raform/nifcloud/db_does_not_have_long_backup_retention/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Nifcloud RDB Has Backup Retention Less Than 2 Day",
"queryName": "(Beta) Nifcloud RDB Has Backup Retention Less Than 2 Day",
"severity": "MEDIUM",
"line": 1,
"fileName": "positive1.tf"
},
{
"queryName": "Nifcloud RDB Has Backup Retention Less Than 2 Day",
"queryName": "(Beta) Nifcloud RDB Has Backup Retention Less Than 2 Day",
"severity": "MEDIUM",
"line": 1,
"fileName": "positive2.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/db_has_public_access/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "fb387023-e4bb-42a8-9a70-6708aa7ff21b",
"queryName": "Nifcloud RDB Has Public DB Access",
"queryName": "(Beta) Nifcloud RDB Has Public DB Access",
"severity": "HIGH",
"category": "Networking and Firewall",
"descriptionText": "The rdb has public db access",
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/nifcloud/db_has_public_access/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "Nifcloud RDB Has Public DB Access",
"queryName": "(Beta) Nifcloud RDB Has Public DB Access",
"severity": "HIGH",
"line": 1,
"fileName": "positive.tf"
Expand Down
Loading
Loading