feat(query): add new query for tencentcloud CDB resource #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
community
|
This is my local test |
|
Hello |
gabriel-cx
suggested changes
Jun 17, 2024
assets/queries/terraform/tencentcloud/cdb_instance_using_default_intranet_port/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/terraform/tencentcloud/cdb_instance_without_backup_policy/query.rego
Outdated
Show resolved
Hide resolved
|
@SevenEarth thanks for the contribution! kindly take a look into the code review. |
ArturRibeiro-CX
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Hey @SevenEarth, thanks for your contribution so far!
Kindly review the requested changes please.
assets/queries/terraform/tencentcloud/cdb_instance_internet_service_enabled/query.rego
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel <[email protected]>
Co-authored-by: Gabriel <[email protected]>
ArturRibeiro-CX
approved these changes
Jun 18, 2024
gabriel-cx
approved these changes
Jun 18, 2024
Thank all of yours, I will notice this issue in the next development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, There is something new query for TencentCloud TKE resource:
cdb_instance_internet_service_enabled
cdb_instance_using_default_intranet_port
cdb_instance_without_backup_policy
Please help review the PR
Thanks
I submit this contribution under the Apache-2.0 license.