Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(nifcloud): update nifcloud queries metadata and functionality #7206

Merged
merged 10 commits into from
Sep 27, 2024
Merged

update(nifcloud): update nifcloud queries metadata and functionality #7206

merged 10 commits into from
Sep 27, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Jul 18, 2024 •
edited
Loading

Reason for Proposed Changes

  • update Nifcloud queries metadata and functionality;
  • remove Beta tag from all queries;

Proposed Changes

  • update queries severities to correctly align with already existent KICS logic;
  • update queries categories to correctly align with already existent KICS logic;
  • update queries metadata to proper reflect queries functionality;
  • add a rule to check if publicly_accessible is not defined for Nifcloud RDB Has Public DB Access query;
  • remove Beta tag from all queries;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner July 18, 2024 17:06
@github-actions github-actions bot added the query New query feature label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

JulioSCX
JulioSCX previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JulioSCX JulioSCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job investigating, reviewing and updating all the queries!

@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – e64d2a01-9971-457f-8707-69357ac3d498

No New Or Fixed Issues Found

EduardoSemanas
EduardoSemanas approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArturRibeiro-CX ArturRibeiro-CX merged commit 7ae16b7 into master Sep 27, 2024
28 checks passed
@ArturRibeiro-CX ArturRibeiro-CX deleted the AST-50621 branch September 27, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoSemanas EduardoSemanas EduardoSemanas approved these changes

@JulioSCX JulioSCX JulioSCX left review comments

Assignees
No one assigned
Labels
query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArturRibeiro-CX @EduardoSemanas @JulioSCX @cx-ruiaraujo