Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(password): fix missing positive results from Password and Secrets query #7223

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

Reason for Proposed Changes

  • Three positive files were missing from the results (positive 8, positive 44, positive 49).

Proposed Changes

  • Update positive and negative files that were invalid and not parsed by KICS.
  • Fix the numeric naming of negative tests to follow the existing logic.

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner August 1, 2024 16:53
Copy link

gitguardian bot commented Aug 1, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266030 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266006 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/negative42.yaml View secret
4266006 Triggered Generic Password c01414b assets/queries/common/passwords_and_secrets/test/negative32.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions github-actions bot added bug Something isn't working query New query feature labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX changed the title bug(password): fix missing positive results from Password and Secrets query fix(password): fix missing positive results from Password and Secrets query Aug 1, 2024
@github-actions github-actions bot removed the bug Something isn't working label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Logo
Checkmarx One – Scan Summary & Details714338eb-3c38-445d-8137-5e0f5a84c25a

No New Or Fixed Issues Found

EduardoSemanas
EduardoSemanas previously approved these changes Aug 13, 2024
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduardoSemanas EduardoSemanas merged commit d51ee51 into master Aug 13, 2024
27 checks passed
@EduardoSemanas EduardoSemanas deleted the AST-45014 branch August 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants