Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was a bit unexpected, but it seems to be related to machine precision, since it was very difficult to get the model to fail even with the worst case scenario in many cases. The background is that the current definition of
softplus
lead to some ill-behaved gradients for large negative values.Which eventually manifested like so:
There is a PR on upstream to fix this, but I am adding the adjoint here so we don't have to worry about the dependencies too much for the time being. Defining the
adjoint
forsoftplus
fixes this.cc @rkurchin