Need to import from submodules before doing top-level convenience export, also other minor fixes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed this in main module file Signed-off-by: Rachel Kurchin <[email protected]>
this must not be covered by tests because featurizations aren't lists anymore so we can't iterate on them Signed-off-by: Rachel Kurchin <[email protected]>
Signed-off-by: Rachel Kurchin <[email protected]>
Signed-off-by: Rachel Kurchin <[email protected]>
…g that Signed-off-by: Rachel Kurchin <[email protected]>
rkurchin
changed the title
It used to be a Union type included Vector{Integer}, but it should have been Vector{<:Integer}
Also added a test to disambiguate this case a bit better.
Signed-off-by: Rachel Kurchin <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Rachel Kurchin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 80.57% 81.08% +0.51%
==========================================
Files 11 11
Lines 314 312 -2
==========================================
Hits 253 253
+ Misses 61 59 -2
Continue to review full report at Codecov.
|
formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
thazhemadam
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed this in main module file, may just tag this as v0.3.1 to also test docs build fix that @thazhemadam will hopefully add