streamable: Enable isort + more mypy
#10539
Conversation
|
This pull request fixes 1 alert when merging 6ad370d5d21c8426121c899c4974a2e679183115 into 018b67f - view on LGTM.com fixed alerts:
|
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
6ad370d
to
a71a9ec
Compare
|
This pull request fixes 1 alert when merging a71a9ec933baf5436ec046dc557d9e2e88bf1bf8 into 5ac986c - view on LGTM.com fixed alerts:
|
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
a71a9ec
to
a6e87c8
Compare
|
This pull request fixes 1 alert when merging a6e87c8 into 0e29dbc - view on LGTM.com fixed alerts:
|
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
a6e87c8
to
c6b731d
Compare
|
This pull request fixes 1 alert when merging c6b731dc9834069820e50c30f8627f3c0921277d into 0e29dbc - view on LGTM.com fixed alerts:
|
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
c6b731d
to
1bd86bd
Compare
And fix all the mypy issues.
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
1bd86bd
to
c772b20
Compare
There was a problem hiding this comment.
See how many places you can use object instead of Any. Any lets you both put anything in there as well as do anything with what is in there. object only does the former while restricting the usage to what object provides (and everything inherits from object). It might point out some opportunities to further detail hints as well.
Other comments are just a quick pass here since there are soooo many Any. Hopefully they can be peared down a bit.
@altendky bb691d6 and 0f30693 is what i could figure in reasonable time.. Touching others ends up up with mypy errors in the rest of the codebase and i don't feel like thats the point here then. Feel free to provide some commits with changes if you have something specific in mind though to eliminate more of the |
xdustinface
force-pushed
the
pr-streamable-mypy-isort
branch
from
479b73e
to
19e233a
Compare
* isort: Fix `streamable.py` and `test_streamable.py` * mypy: Drop `streamable.py` and `test_streamable.py` form exclusion And fix all the mypy issues. * Fix `pylint` * Introduce `ParseFunctionType` and `StreamFunctionType` * Use `object` instead of `Type[Any]` for `is_type_*` functions * Some `Any` -> `object` * Use `typing.overload` for `recurse_jsonify` * Move some comments * Drop `Union`, use `Literal` properly * Explicitly ignore the return of `f_type.parse` Co-authored-by: Kyle Altendorf <[email protected]> * Merge two `recurse_jsonify` overloads * Typing for the base definition of `recurse_jsonify` Co-authored-by: Kyle Altendorf <[email protected]>
* isort: Fix `streamable.py` and `test_streamable.py` * mypy: Drop `streamable.py` and `test_streamable.py` form exclusion And fix all the mypy issues. * Fix `pylint` * Introduce `ParseFunctionType` and `StreamFunctionType` * Use `object` instead of `Type[Any]` for `is_type_*` functions * Some `Any` -> `object` * Use `typing.overload` for `recurse_jsonify` * Move some comments * Drop `Union`, use `Literal` properly * Explicitly ignore the return of `f_type.parse` Co-authored-by: Kyle Altendorf <[email protected]> * Merge two `recurse_jsonify` overloads * Typing for the base definition of `recurse_jsonify` Co-authored-by: Kyle Altendorf <[email protected]>
Currently based on #10509