-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-1645: Some daemon start cleanup #18809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
the
Fixed
Required label for PR that categorizes merge commit message as "Fixed" for changelog
label
Nov 4, 2024
altendky
previously approved these changes
Nov 7, 2024
close and reopen |
arvidn
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! If anything, I would suggest making it mandatory to name the wait_for_start
argument. but it's fine either way
Pull Request Test Coverage Report for Build 11805186875Details
💛 - Coveralls |
arvidn
approved these changes
Nov 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the daemon startup procedure:
chia start daemon
start_new_session
This seems to work well so far in my testing and I believe this will fix both #18677 and #16396
I tested launching the daemon in a variety of ways including
chia start daemon
chia run_daemon
chia_daemon
So far testing was limited to macOS and Linux, Windows needs some additional testing.