Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.7 and some cleanup #144

Merged
merged 13 commits into from
Aug 25, 2023
Merged

Remove python 3.7 and some cleanup #144

merged 13 commits into from
Aug 25, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jul 31, 2023

Remove python 3.7
Remove unused code in setup.py related to macos builds. This code was never actually executed.

Changed MACOSX_DEPLOYMENT_TARGET to macOS 11
@emlowe emlowe changed the title Update macOS target to macOS 11 Update macOS target to macOS 11 and remove python 3.7 Jul 31, 2023
@emlowe
Copy link
Contributor Author

emlowe commented Jul 31, 2023

close

@emlowe emlowe closed this Jul 31, 2023
@emlowe emlowe reopened this Jul 31, 2023
@emlowe emlowe marked this pull request as draft July 31, 2023 18:36
@emlowe
Copy link
Contributor Author

emlowe commented Jul 31, 2023

close and reopn

@emlowe emlowe closed this Jul 31, 2023
@emlowe emlowe reopened this Jul 31, 2023
@emlowe
Copy link
Contributor Author

emlowe commented Jul 31, 2023

close and reopen

@emlowe emlowe closed this Jul 31, 2023
@emlowe emlowe reopened this Jul 31, 2023
This darwin section was never used, and actually couldn't run as the class is only used on Windows
@emlowe emlowe marked this pull request as ready for review August 1, 2023 20:40
@emlowe emlowe changed the title Update macOS target to macOS 11 and remove python 3.7 Remove python 3.7 and some cleanup Aug 24, 2023
@emlowe emlowe requested a review from wallentx August 25, 2023 14:48
@wallentx wallentx merged commit 71d4f1d into main Aug 25, 2023
34 checks passed
@emlowe emlowe deleted the EL.min-macos branch October 4, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants