Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk bump and go upgrade #29

Closed
wants to merge 1 commit into from
Closed

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Jul 12, 2022

You might want to upgrade your upstream fork to 45.6. If you could let me know what changes in your SDK fork, that would be cool. Thank you

@lydia-pierce
Copy link
Collaborator

Thanks for these updates! There should just be two commits to ensure the we can set the minimum commission rate for the validators (the SDK includes this feature in v0.46.0 and beyond, but not in v0.45.x). Here are the two commits: 99ebd92 and 37aa7a0 which can be seen in both of these PRs: #4 and #2

@lydia-pierce
Copy link
Collaborator

Thanks for making this PR @faddat ! We have decided we are just going to wait until the v0.46 release of the sdk, since it already includes minimum commission and other great features. Closing in favor of #31

@alanwilhelm
Copy link

It has been a while but I assume since cosmwasm is going to skip 46 you are as well?

@lydia-pierce
Copy link
Collaborator

@alanwilhelm We have and will use the most up-to-date version of the sdk that cosmwasm uses, so once they release a version with 47, we will use that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants