Skip to content

Commit

Permalink
Merge pull request #1078 from Chilledheart/mac_disable_cares_build
Browse files Browse the repository at this point in the history
mac: disable c-ares custom dns resolver
  • Loading branch information
Chilledheart authored Sep 1, 2024
2 parents 6ce24c3 + c14de2d commit c06fbf3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,9 @@ func buildStageGenerateBuildScript() {

if systemNameFlag == "darwin" {
cmakeArgs = append(cmakeArgs, fmt.Sprintf("-DCMAKE_OSX_DEPLOYMENT_TARGET=%s", macosxVersionMinFlag))
// macos from 15 doesn't like custom dns resolver such as c-ares
// because it need permission to access local dns server
cmakeArgs = append(cmakeArgs, fmt.Sprintf("-DUSE_CARES=%s", "OFF"))
if macosxUniversalBuildFlag {
cmakeArgs = append(cmakeArgs, "-DCMAKE_OSX_ARCHITECTURES=arm64;x86_64")
} else {
Expand Down

0 comments on commit c06fbf3

Please sign in to comment.