Add edid override for AYANEO GEEK. #54
Conversation
This fixes an edid parse failure by patching out a bad section in the edid, and seems to fix ValveSoftware/gamescope#864.
| @@ -14,6 +14,11 @@ elif [[ ":$PRODUCT_LIST_AIR_PLUS:" =~ ":$PRODUCT_NAME:" ]]; then | |||
| elif [[ ":$PRODUCT_LIST_2:" =~ ":$PRODUCT_NAME:" ]]; then | |||
| echo "AYA NEO 2 SERIES" | |||
| $DQ_PATH/scripts/ayaneo/2/2.sh | |||
|
|
|||
| if [[ "GEEK" == "$PRODUCT_NAME" ]]; then | |||
There was a problem hiding this comment.
This match should be surrounded with : to avoid partial matches.
There was a problem hiding this comment.
Hmm, I'm doing a direct match here using ==. Is that still necessary?
There was a problem hiding this comment.
If we're going to do this then I'd prefer to have a PRODUCT_LIST_GEEK and remove geek from the 2 list. Add the audio quirk to the geek.sh the 2.sh has.
|
Note there are AYANEO GEEK devices out there with a 1200p panel (I believe the same as the AYANEO 2) instead of the default 800p panel which I have. I'm not sure how to distinguish those at this point though. Perhaps we could check the original edid shasum and only patch in that case (my original one's sha256sum is 847db288c70f197534a581b5807540df09273150e7577d650d42db935385a44b)? Is that available in the context where this script runs? |
|
CC @ruineka too :) |
| exit 1 | ||
| fi | ||
|
|
||
| if [[ $USE_FIRMWARE_OVERRIDES == 1 ]]; then |
There was a problem hiding this comment.
We'll need to find a way to differentiate the 800p and 1200p models here.
|
We might be having a proper fix underway soon. Don't merge this unless we have too. |
|
https://gitlab.freedesktop.org/emersion/libdisplay-info/-/merge_requests/164 is the code workaround that will fix this particular instance. |
Indeed it is, any chance you can comment under there where someone is asking about permission to list the EDID under MIT? I added my EDID as well but they used yours as the sample to be used. |
|
has there been any movement on the patch for this, or a way to ID the 800P display units only? |
This fixes an edid parse failure by patching out a bad section in the edid, and seems to fix
ValveSoftware/gamescope#864.