Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add redis sentinel support #5593

Merged
merged 2 commits into from
May 10, 2023

Conversation

kontrollanten
Copy link
Contributor

Description

Adds redis sentinel support.

Related issues

closes #5141

Has this been tested?

Yes, manually. By setting up the following sentinel and connecting:

version: '2'

services:
  redis-sentinel:
    image: docker.io/bitnami/redis-sentinel:7.0
    environment:
      - REDIS_MASTER_HOST=127.0.0.1
    networks:
      - webproxy
    ports:
      - 26379:26379
    volumes:
      - redis-sentinel_data:/bitnami
  redis:
    image: docker.io/bitnami/redis:7.0
    environment:
      # ALLOW_EMPTY_PASSWORD is recommended only for development.
      - ALLOW_EMPTY_PASSWORD=yes
    networks:
      - webproxy
    ports:
      - 6379:6379
    volumes:
      - redis_data:/bitnami
volumes:
  redis-sentinel_data:
    driver: local
  redis_data:
    driver: local

networks:
  webproxy:
    driver: bridge

Not sure if it's worth to setup a test for this feature?

@Chocobozzz
Copy link
Owner

Thanks!

@Chocobozzz Chocobozzz merged commit 674f8dd into Chocobozzz:develop May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis Sentinel support
2 participants