Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README Fix: Use select-single everywhere, fix missing comma in default options #1000

Merged
merged 1 commit into from
Jan 16, 2022
Merged

README Fix: Use select-single everywhere, fix missing comma in default options #1000

merged 1 commit into from
Jan 16, 2022

Conversation

mysliwietzflorian
Copy link
Contributor

Description

  • use select-one consistently (instead of select-single with two occurrences)
  • add missing comma (,) in setup example with default options

Screenshots

Also update repo tags?

image

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • not really needed

@mysliwietzflorian
minor update docs/readme
bb76a57 
- use  `select-one` consistently (instead of `select-single` with two occurrences)
- add missing comma (,) in setup example with default options
@mtriff mtriff added the documentation Pull request that changes documentation label Jan 16, 2022
@mtriff mtriff changed the title minor update to docs (readme) README Fix: Use select-single everywhere, fix missing comma in default options Jan 16, 2022
@mtriff mtriff merged commit 06d4435 into Choices-js:master Jan 16, 2022
@mtriff
Copy link
Member

mtriff commented Jan 16, 2022

Nice one! I've updated the repo tags as well.

@mysliwietzflorian mysliwietzflorian deleted the mysliwietzflorian-patch-1 branch April 13, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtriff mtriff mtriff approved these changes

Assignees
No one assigned
Labels
documentation Pull request that changes documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mysliwietzflorian @mtriff