Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id types #743

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Fix id types #743

merged 3 commits into from
Nov 8, 2019

Conversation

jshjohnson
Copy link
Collaborator

Description

  • Fixes type warnings related to group/choice/item ids

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the chore Pull request that does not change core code label Nov 7, 2019
@jshjohnson jshjohnson merged commit d04031e into master Nov 8, 2019
@jshjohnson jshjohnson deleted the fix-id-types branch November 8, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Pull request that does not change core code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jshjohnson