Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polyfill list #765

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Update polyfill list #765

merged 4 commits into from
Nov 19, 2019

Conversation

jshjohnson
Copy link
Collaborator

Description

Hopefully fixes #764

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the chore Pull request that does not change core code label Nov 18, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #765 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
- Coverage   66.76%   66.56%   -0.21%     
==========================================
  Files          22       22              
  Lines        1315     1319       +4     
==========================================
  Hits          878      878              
- Misses        437      441       +4
Impacted Files Coverage Δ
src/scripts/choices.js 54.29% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214b6e8...165bc33. Read the comment docs.

@cypress
Copy link

cypress bot commented Nov 19, 2019



Test summary

123 0 0 0


Run details

Project Choices
Status Passed
Commit 165bc33
Started Nov 19, 2019 5:48 PM
Ended Nov 19, 2019 5:50 PM
Duration 01:23 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 73

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jshjohnson jshjohnson merged commit 592c326 into master Nov 19, 2019
@jshjohnson jshjohnson deleted the resolve-764 branch November 19, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull request that does not change core code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choices does not work on ie11 due classList.add() multi arguments issue
1 participant