Use single library for SSZ, bls-to-execution-change and presigned-exit-message #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most important part of cleanup is removing |
mksh
force-pushed
the
fixes-bls-to-execution-change
branch
from
f2b0c6a
to
e4f1882
Compare
mksh
changed the title
mksh
changed the title
QAston
reviewed
Aug 21, 2024
jenpaff
reviewed
Aug 22, 2024
jenpaff
reviewed
Aug 22, 2024
jenpaff
approved these changes
Aug 22, 2024
* Command to generate presigned exit message * Docs for presigned-exit-message * Code review feedback
mksh
changed the title
mksh
force-pushed
the
fixes-bls-to-execution-change
branch
from
b730a4c
to
a372991
Compare
- Fix presigned-exit-message format & beacon node sending - Rename Operator traits -> validator - Rename operator module -> operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-requisite for #53
The command
bls-to-execution-changewas not working before, so this adds signature tests and verifies action works with real Holesky validator https://holesky.beaconcha.in/validator/a7c6468e36b0cc23580fd5c4e44b5505db677cfeb2692a5d7992bddac4706981f0bdaf568d565703d6e68e0211912349#depositsA future pre-signed exit message command will use the same genesis validator root values, and reuse most of signing logic, so it is important to cleanup
bls-to-execution-changebefore adding new functionality.