Attachments: don't create an undo action if sliders don't move

Chowdhury-DSP · Jun 1, 2024 · 0053784 · 0053784
1 parent 776aa52
commit 0053784
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/modules/plugin/chowdsp_plugin_state/Frontend/chowdsp_SliderAttachment.cpp b/modules/plugin/chowdsp_plugin_state/Frontend/chowdsp_SliderAttachment.cpp
@@ -104,14 +104,16 @@ void SliderAttachment::sliderDragStarted (juce::Slider*)
 
 void SliderAttachment::sliderDragEnded (juce::Slider*)
 {
-    if (um != nullptr)
+    const auto valueAtEndOfGesture = attachment.param->get();
+    if (um != nullptr && ! juce::approximatelyEqual (valueAtStartOfGesture, valueAtEndOfGesture))
     {
         um->beginNewTransaction();
         um->perform (
             new ParameterAttachmentHelpers::ParameterChangeAction<FloatParameter> (
                 *attachment.param,
                 valueAtStartOfGesture,
-                attachment.param->get()));
+                valueAtEndOfGesture,
+                attachment.pluginState == nullptr ? nullptr : attachment.pluginState->processor));
     }
 
     attachment.endGesture();

diff --git a/modules/plugin/chowdsp_plugin_state/Frontend/chowdsp_SliderChoiceAttachment.cpp b/modules/plugin/chowdsp_plugin_state/Frontend/chowdsp_SliderChoiceAttachment.cpp
@@ -5,6 +5,7 @@ SliderChoiceAttachment::SliderChoiceAttachment (ChoiceParameter& param,
                                                 juce::Slider& paramSlider)
     : SliderChoiceAttachment (param, pluginState.getParameterListeners(), paramSlider, pluginState.undoManager)
 {
+    attachment.pluginState = &pluginState;
 }
 
 SliderChoiceAttachment::SliderChoiceAttachment (ChoiceParameter& param,
@@ -63,14 +64,16 @@ void SliderChoiceAttachment::sliderDragStarted (juce::Slider*)
 
 void SliderChoiceAttachment::sliderDragEnded (juce::Slider*)
 {
-    if (um != nullptr)
+    const auto valueAtEndOfGesture = attachment.param->getIndex();
+    if (um != nullptr && valueAtEndOfGesture != valueAtStartOfGesture)
     {
         um->beginNewTransaction();
         um->perform (
             new ParameterAttachmentHelpers::ParameterChangeAction<ChoiceParameter> (
                 *attachment.param,
                 valueAtStartOfGesture,
-                attachment.param->getIndex()));
+                valueAtEndOfGesture,
+                attachment.pluginState == nullptr ? nullptr : attachment.pluginState->processor));
     }
 
     attachment.endGesture();