Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extent= #7

Merged
merged 15 commits into from
Jun 1, 2017

Conversation

astrofrog
Copy link
Contributor

This works and tests should pass, but I need to add actual tests for this functionality.

Coordinates in "extent" space are converted to array coordinates
for the rescaling and then back to reset the "extent".
@astrofrog
Copy link
Contributor Author

astrofrog commented May 30, 2017

Oops I just duplicated #6 - I'll try and compare carefully and see what makes most sense.

@astrofrog
Copy link
Contributor Author

I'll combine this with #6 tomorrow

@astrofrog
Copy link
Contributor Author

I've now merged this with #6 and significantly expanded test_extent to make sure we catch different special cases. I think this is good to go if tests pass on Travis.

@astrofrog astrofrog mentioned this pull request May 31, 2017
@ChrisBeaumont
Copy link
Owner

Thanks @astrofrog @ppinard -- sorry I missed this originally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants