handling sql errors in file

ChristianTremblay · Aug 26, 2024 · 49c90c8 · 49c90c8
1 parent 62f599a
commit 49c90c8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/BAC0/core/devices/Device.py b/BAC0/core/devices/Device.py
@@ -1067,14 +1067,14 @@ async def initialize_device_from_db(self):
         # Save important properties for reuse
         if self.properties.db_name:
             dbname = self.properties.db_name
+            self._props = self.read_dev_prop(self.properties.db_name)
         else:
             self.log("Missing argument DB", level="info")
             raise ValueError("Please provide db name using device.load_db('name')")
 
         # network = self.properties.network
         pss = self.properties.pss
 
-        self._props = self.read_dev_prop(self.properties.db_name)
         self.points = []
         for point in self.points_from_sql(self.properties.db_name):
             try:

diff --git a/BAC0/db/sql.py b/BAC0/db/sql.py
@@ -291,5 +291,9 @@ def read_dev_prop(self, device_name):
         Device properties retrieved from pickle
         """
         self.log("Reading prop from DB file", level="debug")
-        with open(f"{device_name}.bin", "rb") as file:
-            return pickle.load(file)["device"]
+        try:
+            with open(f"{device_name}.bin", "rb") as file:
+                return pickle.load(file)["device"]
+        except EOFError:
+            self._log.error("Error reading device properties")
+            raise ValueError