Dmm test cleanup #123
Merged
Dmm test cleanup #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Christian,
Ah, I didn't realize that they had a further use, I thought they were
extraneous. In that case should I update the PR to leave them in?
Best,
Drew
…----
Drew Massey
Customer Success
[email protected]
On Thu, Dec 13, 2018 at 3:13 PM Christian Tremblay ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for that. Was the file deleted causing troubles ? I was planning
using this file to make segmentation test with a device having a lot of
points.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#123 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AnNdQVR7AWMGQ3ztnHz7F3yoC2bE8FDcks5u4rTegaJpZM4ZIyuL>
.
|
|
No... it probably need to be better anyway. Just wanted to be sure it was not causing issues. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just made it so that the code was a little more readable and less repetitive.