Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 185 fix #186

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Issue 185 fix #186

merged 6 commits into from
Jan 29, 2020

Conversation

imrePurret
Copy link
Contributor

Replacement of unit active state value with activeText property instead of inactiveText property

@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 51.47% when pulling 952e8bf on imrePurret:issue_185 into 7388ef4 on ChristianTremblay:develop.

@ChristianTremblay ChristianTremblay changed the base branch from master to develop January 29, 2020 00:24
ChristianTremblay
ChristianTremblay requested changes Jan 29, 2020
View reviewed changes
Copy link
Owner

@ChristianTremblay ChristianTremblay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !
Would it be possible to resubmit with develop branch as target. That will remove the conflict with the Discover.py file.

Thanks

@ChristianTremblay ChristianTremblay mentioned this pull request Jan 29, 2020
Closed
@ChristianTremblay ChristianTremblay merged commit d614c7b into ChristianTremblay:develop Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianTremblay ChristianTremblay ChristianTremblay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrePurret @coveralls @ChristianTremblay