Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less extract(), addtl code cleanup, update deps #7137

Merged
merged 9 commits into from
Sep 8, 2024
Merged

Less extract(), addtl code cleanup, update deps #7137

merged 9 commits into from
Sep 8, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description

This PR updates various dependencies and refactors code for improved clarity and type safety.

Key Changes

  • Dependency Updates: Updated npm and composer packages
  • Code Refactoring: Adjusted method signatures for better type safety.
  • Replaced raw SQL queries with ORM methods for database interactions.
  • Updated formatBirthDate method calls and other related methods.

@DAcodedBEAT DAcodedBEAT added Platform: Database Code Smell Package Dependencies javascript Pull requests that update Javascript code php Pull requests that update Php code labels Sep 7, 2024
@DAcodedBEAT DAcodedBEAT self-assigned this Sep 7, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner September 7, 2024 05:23
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team September 7, 2024 05:23
@DAcodedBEAT DAcodedBEAT merged commit 1aa2e8e into master Sep 8, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the less-extracts branch September 8, 2024 22:19
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees

@DAcodedBEAT DAcodedBEAT

Labels
Code Smell javascript Pull requests that update Javascript code Package Dependencies php Pull requests that update Php code Platform: Database
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DAcodedBEAT