Ext 358 pr template #708
Ext 358 pr template #708
Conversation
… be why this file is not working Added to the template with our standard categories
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 28.00% 28.00%
=======================================
Files 42 42
Lines 4795 4795
=======================================
Hits 1343 1343
Misses 3267 3267
Partials 185 185 Continue to review full report at Codecov.
|
| Why you made some of the technical decisions that you made, especially if the | ||
| reasoning is not immediately obvious | ||
|
|
||
| ## Analytics Events Added |
There was a problem hiding this comment.
are analytics events a thing in this repo? Did a quick search on the repo which didn't show anything 🤔
There was a problem hiding this comment.
Oh no I only saw this after I saw the approval and merged! There's a way to prevent that if you make your commenta as change request 😄
There was a problem hiding this comment.
no worries. good point, noted for next time 🙂
There was a problem hiding this comment.
Opened #709 to address 🙂
|
aside from small comment on analytics events, LGTM 🚢 |
Issue
PR template for the CLI was non-functioning
Changes & Rationel
I grabbed a template we were using from another repo and added the relevant information to this PR template.
After some research, I found that there is a high chance that this template was non-functioning because it was in a folder within the .github folder.
Cannot be tested until it is in the master branch, however these changes are very unlikely to break anything (low risk)